Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update amountPerCoin prop in WalletConfig to accept BN #3594

Merged
merged 9 commits into from
Jan 24, 2025
Merged

chore: update amountPerCoin prop in WalletConfig to accept BN #3594

merged 9 commits into from
Jan 24, 2025

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Jan 16, 2025 •
edited
Loading

Summary

This change ensures test wallets can be safely funded with large numerical values.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Torres-ssf Torres-ssf self-assigned this Jan 16, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 16, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 5:17pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 5:17pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 5:17pm

@Torres-ssf Torres-ssf changed the title test: update amountPerCoin prop in WalletConfig to accept BN chore: update amountPerCoin prop in WalletConfig to accept BN Jan 16, 2025
@github-actions github-actions bot added the chore Issue is a chore label Jan 16, 2025
arboleya
arboleya previously approved these changes Jan 16, 2025
View reviewed changes
packages/fuel-gauge/src/contract.test.ts Show resolved Hide resolved
@Torres-ssf Torres-ssf marked this pull request as draft January 16, 2025 14:52
@Torres-ssf Torres-ssf dismissed stale reviews from arboleya and petertonysmith94 via 7fa3ba7 January 23, 2025 16:30
@Torres-ssf Torres-ssf marked this pull request as ready for review January 23, 2025 16:59
@Torres-ssf Torres-ssf enabled auto-merge (squash) January 23, 2025 17:00
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
77.05%(+0.01%) 70.65%(+0.01%) 75.1%(+0%) 77.05%(+0.01%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 68.46%
(-0.09%)		 59%
(+0.54%)		 69.89%
(+0%)		 68.2%
(-0.08%)

@Torres-ssf Torres-ssf merged commit d1825c9 into master Jan 24, 2025
24 checks passed
@Torres-ssf Torres-ssf deleted the st/chore/made-wallet-config-accept-bn branch January 24, 2025 08:51
@github-actions github-actions bot mentioned this pull request Jan 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@danielbate danielbate danielbate approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Torres-ssf @arboleya @danielbate @petertonysmith94